Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usage from within Discord #369

Open
4 of 6 tasks
Bios-Marcel opened this issue Dec 22, 2024 · 2 comments
Open
4 of 6 tasks

Support usage from within Discord #369

Bios-Marcel opened this issue Dec 22, 2024 · 2 comments

Comments

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Dec 22, 2024

I think it'd be interesting to be usable as a Discord activity. Discord activities are easy for everyone to use and improve the games discoverability.

It's a hard requirement not to be bound to Discord though. Everything needs to function without it.
This means, we should avoid relying on their SDK or anything like that. Everything must be losely coupled.

AFAIK right now there are 2 issues.

  • The inline scripts need to be downloaded scripts instead, as per discord security policy ... god knows why
  • Inline event handlers need to be moved into the JS code
  • The websocket URL needs to be aware of the proxy. (iframe start location can be used)
  • Session management needs to be integrated somehow.
  • Disable clients per ip setting
  • Solve Ultrawide support #308

    This happens quite often on discord, due to the layout when playing without fullscreen

Session Management

For this we need to use the instanceid discord provides: https://discord.com/developers/docs/activities/development-guides#using-instanceid

We need to make sure people at least automatically join the instance or can see them even if they are private. That way, we only need to make slight changes to the API.

@Bios-Marcel
Copy link
Member Author

Bios-Marcel commented Dec 23, 2024

Steps 1 to 3 were done with 6cc2e41

Session management is still missing. The cherry on top would be to properly integrate, however, that would require loading the discord sdk afaik. If it is a simple small file, I will consider it, otherwise we'll go for half-assed integration for now.

@Bios-Marcel
Copy link
Member Author

A first version of the app is deployed already: https://discord.com/oauth2/authorize?client_id=1320396325925163070

I think it should be startable by anyone. However, it is not discoverable for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant