Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic templating steps #370

Closed
Bios-Marcel opened this issue Dec 22, 2024 · 2 comments
Closed

Remove dynamic templating steps #370

Bios-Marcel opened this issue Dec 22, 2024 · 2 comments
Labels
enhancement improvement of any kind

Comments

@Bios-Marcel
Copy link
Member

Bios-Marcel commented Dec 22, 2024

Currently templating is used for multiple things:

  • constant values, such as the drawing board dimensions

  • translations (Which is also constant)

  • Stuff that's not compile time constant, but runtime constant, such as the RootPath

  • Dynamic stuff, such as the LobbyID

The lobby id is only really needed for the socket and can be retrieved from the URL bar.
The other dynamic values can be applied lazily or at startup.

This is a blocker for #369

The goal here, is to optimize response time and reduce runtime complexity, as templating can fail.

@Bios-Marcel Bios-Marcel added the enhancement improvement of any kind label Dec 22, 2024
@Bios-Marcel
Copy link
Member Author

I made a little thinking error ... the translation are somewhat constant, but need to be selected depending on user locale. Therefore it might be better to just do it dynamically after all.

@Bios-Marcel
Copy link
Member Author

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement of any kind
Projects
None yet
Development

No branches or pull requests

1 participant