Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
larsoner authored Jul 16, 2024
1 parent 75682d3 commit 4182539
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion mne/io/egi/egi.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def read_raw_egi(
exclude=None,
preload=False,
channel_naming="E%d",
*,
events_as_annotations=False,
verbose=None,
) -> "RawEGI":
Expand Down Expand Up @@ -138,12 +139,14 @@ def read_raw_egi(
Channel naming convention for the data channels. Defaults to ``'E%%d'``
(resulting in channel names ``'E1'``, ``'E2'``, ``'E3'``...). The
effective default prior to 0.14.0 was ``'EEG %%03d'``.
.. versionadded:: 0.14.0
events_as_annotations : bool
If True, annotations are created from experiment events. If False (default),
synthetic trigger channels are created from experiment events. See the Notes
section for details.
.. versionadded:: 0.14.0
.. versionadded:: 1.7.0
%(verbose)s
Returns
Expand Down
2 changes: 1 addition & 1 deletion mne/io/egi/tests/test_egi.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_io_egi_mff(events_as_annotations):
# Grab the first annotation. Should be the first "DIN1" event.
assert len(raw.annotations)
onset, dur, desc, _ = raw.annotations[0].values()
assert np.isclose(onset, 2.438)
assert_allclose(onset, 2.438)
assert np.isclose(dur, 0)
assert desc == "DIN1"
# grab the DIN1 channel
Expand Down

0 comments on commit 4182539

Please sign in to comment.