Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buffer row count console log #722

Merged
merged 1 commit into from
May 23, 2024

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented May 21, 2024

Description

This PR removes a console log statement.

Motivation and Context

roughHeights.js logs the value of bufferRowCount whenever this variable is defined. This console log introduces a lot of noise in production, and most of the time the row count is just 0. This statement is probably for debugging purpose only during local development. No other JS file has such statement. Could we remove it?

How Has This Been Tested?

No test needed.

Screenshots (if appropriate):

This is what we see in the browser console in production before removing this console log:

Screenshot 2024-05-21 at 11 14 32

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@tuliren tuliren marked this pull request as ready for review May 21, 2024 18:17
Copy link
Collaborator

@pradeepnschrodinger pradeepnschrodinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Yea this can be safetly removed.

@pradeepnschrodinger pradeepnschrodinger self-assigned this May 22, 2024
@pradeepnschrodinger pradeepnschrodinger merged commit c90240b into schrodinger:master May 23, 2024
6 checks passed
@pradeepnschrodinger
Copy link
Collaborator

Released with v2.0.11.
Thanks for the PR.

@tuliren tuliren deleted the remove-console-log branch May 23, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants