Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of npm bin #710

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Remove usages of npm bin #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
283cc2d
Replace npm bin with npx
pradeepnschrodinger Dec 2, 2023
aea3e64
Remove npx since npm run adds 'node_modules/.bin' to path
pradeepnschrodinger Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build_helpers/buildStaticSite.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/bash
set -e
PATH=$(npm bin):$PATH
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this the npm bin path was added so that the commands below (like webpack) can be executed.

So I initially planned on using npx or npm exec to execute them, but it turns out that these are no longer required.

As per the docs for npm run:

In addition to the shell's pre-existing PATH, npm run adds node_modules/.bin to the PATH provided to scripts. Any binaries provided by locally-installed dependencies can be used without the node_modules/.bin prefix.


rm -rf ./__site__
rm -rf ./__site_prerender__
Expand Down
1 change: 0 additions & 1 deletion build_helpers/startSiteDevServer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/bash
set -e
PATH=$(npm bin):$PATH

rm -rf ./__site__
rm -rf ./__site_prerender__
Expand Down