wip

scality · Jan 9, 2025 · 76539d6 · 76539d6
1 parent e3c7e33
commit 76539d6
Show file tree

Hide file tree

Showing 92 changed files with 780 additions and 621 deletions.
diff --git a/.github/dockerfiles/mongodb/conf/initReplicaSet.js b/.github/dockerfiles/mongodb/conf/initReplicaSet.js
@@ -1,4 +1,5 @@
+/* eslint-disable no-undef */
 rs.initiate({
-    _id: "rs0",
-    members: [{ _id: 0, host: "127.0.0.1:27018" }]
+    _id: 'rs0',
+    members: [{ _id: 0, host: '127.0.0.1:27018' }]
 });
diff --git a/bin/backbeat.js b/bin/backbeat.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';  
 
 const werelogs = require('werelogs');
 

diff --git a/.eslintrc → eslint.config.mjs b/.eslintrc → eslint.config.mjs
@@ -1,12 +1,28 @@
-{
-    "extends": "scality",
-    "parserOptions": {
-        "ecmaVersion": 2020
+import mocha from "eslint-plugin-mocha";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends("scality"), {
+    plugins: {
+        mocha,
     },
-    "plugins": [
-        "mocha"
-    ],
-    "rules": {
+
+    languageOptions: {
+        ecmaVersion: 2020,
+        sourceType: "script",
+    },
+
+    rules: {
         "object-curly-newline": "off",
         "import/newline-after-import": "off",
         "import/order": "off",
@@ -37,13 +53,15 @@
         "no-undef-init": "off",
         "newline-per-chained-call": "off",
         "no-useless-escape": "off",
+        "no-redeclare":"off",
         "mocha/no-exclusive-tests": "error"
     },
-    "settings": {
-        "import/resolver": {
-          "node": {
-            "paths": ["/backbeat/node_modules", "node_modules"]
-          }
+
+    settings: {
+        'import/resolver': {
+            node: {
+                paths: ["/backbeat/node_modules", "node_modules"]
+            }
         }
-      }
-}
+    },
+}];
diff --git a/extensions/gc/GarbageCollector.js b/extensions/gc/GarbageCollector.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const { EventEmitter } = require('events');
 

diff --git a/extensions/gc/GarbageCollectorProducer.js b/extensions/gc/GarbageCollectorProducer.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';  
 
 const { Logger } = require('werelogs');
 

diff --git a/extensions/gc/service.js b/extensions/gc/service.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const { errors } = require('arsenal');
 const werelogs = require('werelogs');

diff --git a/extensions/index.js b/extensions/index.js
@@ -10,7 +10,7 @@ fs.readdirSync(__dirname).forEach(moduleDir => {
         try {
             indexStat = fs.statSync(
                 path.join(__dirname, moduleDir, 'index.js'));
-        } catch (err) {} // eslint-disable-line no-empty
+        } catch {} // eslint-disable-line no-empty
         if (indexStat) {
             extensions[moduleDir] = require(`./${moduleDir}`);
         }

diff --git a/extensions/ingestion/IngestionQueuePopulator.js b/extensions/ingestion/IngestionQueuePopulator.js
@@ -100,7 +100,7 @@ class IngestionQueuePopulator extends QueuePopulatorExtension {
             try {
                 const metaHeaders = JSON.parse(userMD);
                 existingIDHeader = metaHeaders[zenkoIDHeader];
-            } catch (err) {
+            } catch {
                 this.log.trace('malformed user metadata', {
                     method: 'IngestionQueuePopulator.filter',
                     bucket: entry.bucket,

diff --git a/extensions/ingestion/constants.js b/extensions/ingestion/constants.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const testIsOn = process.env.CI === 'true';
 

diff --git a/extensions/lifecycle/LifecycleQueuePopulator.js b/extensions/lifecycle/LifecycleQueuePopulator.js
@@ -7,7 +7,7 @@ const { mpuBucketPrefix } = constants;
 const QueuePopulatorExtension =
     require('../../lib/queuePopulator/QueuePopulatorExtension');
 const { authTypeAssumeRole } = require('../../lib/constants');
-const uuid = require('uuid/v4');
+const { v4: uuid } = require('uuid');
 const safeJsonParse = require('./util/safeJsonParse');
 const { LifecycleMetrics } = require('./LifecycleMetrics');
 const LIFECYCLE_BUCKETS_ZK_PATH = '/data/buckets';

diff --git a/extensions/lifecycle/bucketProcessor/LifecycleBucketProcessor.js b/extensions/lifecycle/bucketProcessor/LifecycleBucketProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const { Logger } = require('werelogs');

diff --git a/extensions/lifecycle/bucketProcessor/task.js b/extensions/lifecycle/bucketProcessor/task.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const werelogs = require('werelogs');

diff --git a/extensions/lifecycle/conductor/LifecycleConductor.js b/extensions/lifecycle/conductor/LifecycleConductor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const schedule = require('node-schedule');

diff --git a/extensions/lifecycle/conductor/service.js b/extensions/lifecycle/conductor/service.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const werelogs = require('werelogs');

diff --git a/extensions/lifecycle/objectProcessor/LifecycleObjectExpirationProcessor.js b/extensions/lifecycle/objectProcessor/LifecycleObjectExpirationProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const LifecycleObjectProcessor = require('./LifecycleObjectProcessor');
 const LifecycleDeleteObjectTask =

diff --git a/extensions/lifecycle/objectProcessor/LifecycleObjectProcessor.js b/extensions/lifecycle/objectProcessor/LifecycleObjectProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const { EventEmitter } = require('events');
 const Logger = require('werelogs').Logger;

diff --git a/extensions/lifecycle/objectProcessor/LifecycleObjectTransitionProcessor.js b/extensions/lifecycle/objectProcessor/LifecycleObjectTransitionProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 const assert = require('assert');
 const async = require('async');
 

diff --git a/extensions/lifecycle/objectProcessor/task.js b/extensions/lifecycle/objectProcessor/task.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const werelogs = require('werelogs');

diff --git a/extensions/lifecycle/tasks/LifecycleRequeueTask.js b/extensions/lifecycle/tasks/LifecycleRequeueTask.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 

diff --git a/extensions/lifecycle/tasks/LifecycleResetTransitionInProgressTask.js b/extensions/lifecycle/tasks/LifecycleResetTransitionInProgressTask.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const { LifecycleRequeueTask } = require('./LifecycleRequeueTask');
 

diff --git a/extensions/lifecycle/tasks/LifecycleRetriggerRestoreTask.js b/extensions/lifecycle/tasks/LifecycleRetriggerRestoreTask.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const { LifecycleRequeueTask } = require('./LifecycleRequeueTask');
 

diff --git a/extensions/lifecycle/tasks/LifecycleTask.js b/extensions/lifecycle/tasks/LifecycleTask.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const { errors, versioning } = require('arsenal');

diff --git a/extensions/lifecycle/tasks/LifecycleTaskV2.js b/extensions/lifecycle/tasks/LifecycleTaskV2.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const { errors } = require('arsenal');

diff --git a/extensions/lifecycle/tasks/LifecycleUpdateTransitionTask.js b/extensions/lifecycle/tasks/LifecycleUpdateTransitionTask.js
@@ -185,7 +185,7 @@ class LifecycleUpdateTransitionTask extends BackbeatTask {
                 }
                 try {
                     assert.notDeepStrictEqual(oldLocation, newLocation);
-                } catch (err) {
+                } catch {
                     log.info('duplicate location update, skipping',
                     Object.assign({
                         method:

diff --git a/extensions/mongoProcessor/MongoQueueProcessor.js b/extensions/mongoProcessor/MongoQueueProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 

diff --git a/extensions/mongoProcessor/constants.js b/extensions/mongoProcessor/constants.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 
 const constants = {

diff --git a/extensions/mongoProcessor/mongoProcessorTask.js b/extensions/mongoProcessor/mongoProcessorTask.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const werelogs = require('werelogs');
 const { errors } = require('arsenal');

diff --git a/extensions/mongoProcessor/utils/BucketMemState.js b/extensions/mongoProcessor/utils/BucketMemState.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 // get Bucket Info from Mongo for given location every 1 minute per consumer
 const REFRESH_TIMER = 60000;

diff --git a/extensions/mongoProcessor/utils/contentTypeHelper.js b/extensions/mongoProcessor/utils/contentTypeHelper.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 function _getDataContent(entry) {
     const contentLength = entry.getContentLength();

diff --git a/extensions/notification/queueProcessor/QueueProcessor.js b/extensions/notification/queueProcessor/QueueProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const { EventEmitter } = require('events');
 const Logger = require('werelogs').Logger;

diff --git a/extensions/notification/queueProcessor/task.js b/extensions/notification/queueProcessor/task.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 const assert = require('assert');
 const { errors } = require('arsenal');
 const async = require('async');

diff --git a/extensions/notification/utils/auth.js b/extensions/notification/utils/auth.js
@@ -9,7 +9,7 @@ function getAuthFilePath(fileName) {
         try {
             fs.accessSync(path, fs.F_OK | fs.R_OK);
             return path;
-        } catch (e) {
+        } catch {
             return null;
         }
     }

diff --git a/extensions/oplogPopulator/OplogPopulatorTask.js b/extensions/oplogPopulator/OplogPopulatorTask.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const werelogs = require('werelogs');
 const { errors } = require('arsenal');

diff --git a/extensions/oplogPopulator/modules/Connector.js b/extensions/oplogPopulator/modules/Connector.js
@@ -121,7 +121,7 @@ class Connector extends EventEmitter {
      * @returns {undefined}
      */
     updatePartitionName() {
-        this._config['offset.partition.name'] = `partition-${uuid.v4()}`;
+        this._config['offset.partition.name'] = `partition-${uuid()}`;
     }
 
     /**

diff --git a/extensions/oplogPopulator/modules/ConnectorsManager.js b/extensions/oplogPopulator/modules/ConnectorsManager.js
@@ -111,7 +111,7 @@ class ConnectorsManager extends EventEmitter {
      * @returns {string} generated connector name
      */
     _generateConnectorName() {
-        return `${this._prefix}${constants.defaultConnectorName}-${uuid.v4()}`;
+        return `${this._prefix}${constants.defaultConnectorName}-${uuid()}`;
     }
 
     /**

diff --git a/extensions/replication/constants.js b/extensions/replication/constants.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const testIsOn = process.env.CI === 'true';
 

diff --git a/extensions/replication/failedCRR/FailedCRRConsumer.js b/extensions/replication/failedCRR/FailedCRRConsumer.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';  
 
 const { StatsModel } = require('arsenal').metrics;
 const Logger = require('werelogs').Logger;

diff --git a/extensions/replication/failedCRR/FailedCRRProducer.js b/extensions/replication/failedCRR/FailedCRRProducer.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';  
 
 const { Logger } = require('werelogs');
 

diff --git a/extensions/replication/queueProcessor/QueueProcessor.js b/extensions/replication/queueProcessor/QueueProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 const { EventEmitter } = require('events');

diff --git a/extensions/replication/queueProcessor/task.js b/extensions/replication/queueProcessor/task.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 const async = require('async');
 const assert = require('assert');
 const werelogs = require('werelogs');

diff --git a/extensions/replication/replay/ReplayProducer.js b/extensions/replication/replay/ReplayProducer.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';  
 
 const { Logger } = require('werelogs');
 

diff --git a/extensions/replication/replicationStatusProcessor/ReplicationStatusProcessor.js b/extensions/replication/replicationStatusProcessor/ReplicationStatusProcessor.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const async = require('async');
 

diff --git a/extensions/replication/replicationStatusProcessor/task.js b/extensions/replication/replicationStatusProcessor/task.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const werelogs = require('werelogs');
 

diff --git a/extensions/replication/tasks/CopyLocationTask.js b/extensions/replication/tasks/CopyLocationTask.js
@@ -1,5 +1,5 @@
 const async = require('async');
-const uuid = require('uuid/v4');
+const { v4: uuid } = require('uuid');
 
 const { errors, jsutil, models } = require('arsenal');
 const { ObjectMD } = models;
@@ -227,7 +227,7 @@ class CopyLocationTask extends BackbeatTask {
             });
             attachReqUids(sourceReq, log);
             sourceReq.on('error', err => {
-                // eslint-disable-next-line no-param-reassign
+                 
                 if (err.statusCode === 404) {
                     log.error('the source object was not found', Object.assign({
                         method: 'CopyLocationTask._getAndPutObjectOnce',

diff --git a/extensions/replication/tasks/MultipleBackendTask.js b/extensions/replication/tasks/MultipleBackendTask.js
@@ -1,5 +1,5 @@
 const async = require('async');
-const uuid = require('uuid/v4');
+const { v4: uuid } = require('uuid');
 
 const errors = require('arsenal').errors;
 const jsutil = require('arsenal').jsutil;

diff --git a/extensions/replication/tasks/UpdateReplicationStatus.js b/extensions/replication/tasks/UpdateReplicationStatus.js
@@ -158,7 +158,7 @@ class UpdateReplicationStatus extends BackbeatTask {
             const soureEntryTags = sourceEntry.getTags();
             const refreshedEntryTags = refreshedEntry.getTags();
             assert.deepStrictEqual(soureEntryTags, refreshedEntryTags);
-        } catch (e) {
+        } catch {
             return refreshedEntry.toPendingEntry(sourceEntry.getSite());
         }
         return refreshedEntry.toCompletedEntry(sourceEntry.getSite());

diff --git a/lib/BackbeatConsumer.js b/lib/BackbeatConsumer.js
@@ -808,8 +808,8 @@ class BackbeatConsumer extends EventEmitter {
         const self = this;
         let lastBootstrapId;
         let producer; // eslint-disable-line prefer-const
-        let producerTimer; // eslint-disable-line prefer-const
-        let consumerTimer; // eslint-disable-line prefer-const
+        let producerTimer;  
+        let consumerTimer;  
         function consumeCb(err, messages) {
             if (err) {
                 return undefined;

diff --git a/lib/CircuitBreaker.js b/lib/CircuitBreaker.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 /* eslint no-param-reassign: 0 */
 
 const { ZenkoMetrics } = require('arsenal').metrics;

diff --git a/lib/Config.js b/lib/Config.js
@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line
+'use strict';  
 
 const assert = require('assert');
 const { EventEmitter } = require('events');