Get curated extensions from create-eth repository

[damianmarti]

scaffold-eth/create-eth#155 should be merged before merging this.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
scaffoldeth-io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2024 6:42am

[carletex]

Thanks for this Damu!

This is getting the data on the client everytime for every user. I don't think we need that here.

Let's get the data from the server (getStaticProps). Same as 3rdparty extensions + leave the 6hours cache.

[damianmarti]

Thanks for this Damu!

This is getting the data on the client everytime for every user. I don't think we need that here.

Let's get the data from the server (getStaticProps). Same as 3rdparty extensions + leave the 6hours cache.

Thanks for the review!!

Changed this and I changed to use installCommand from JSON or to use the default one if it's not set.

Fixed a bug with the branch too, the installCommands from https://scaffoldeth.io/extensions are not showing the branch name when needed.

[Pabl0cks]

Thanks for tackling this Damu!! Adding extensions will be much smoother now ♥

Should we use this PR to filter out external extensions uploaded to bg app (/builds) that may be duplicated as curated? Or create a new PR instead?

Something like this could do the job:

const formattedExtensions = data
      .filter((ext: any) => !ext.branch.includes("scaffold-eth/create-eth-extensions"))
      .map((ext: any) => {
        const githubUrlParts = ext.branch.split("/");
        const githubUsername = githubUrlParts[3];
        const repoName = githubUrlParts[4];

        let installCommand = `npx create-eth@latest -e ${githubUsername}/${repoName}`;

        if (githubUrlParts.length > 5) {
          const branch = githubUrlParts[6];
          installCommand = `${installCommand}:${branch}`;
        }

        return {
          name: ext.name,
          description: ext.desc,
          github: ext.branch,
          installCommand,
          builder: ext.builder,
          coBuilders: ext.coBuilders || [],
          youtube: ext.videoUrl || null,
        };
      });

[damianmarti]

Thanks for tackling this Damu!! Adding extensions will be much smoother now ♥

Should we use this PR to filter out external extensions uploaded to bg app (/builds) that may be duplicated as curated? Or create a new PR instead?

Something like this could do the job:

const formattedExtensions = data
      .filter((ext: any) => !ext.branch.includes("scaffold-eth/create-eth-extensions"))
      .map((ext: any) => {
        const githubUrlParts = ext.branch.split("/");
        const githubUsername = githubUrlParts[3];
        const repoName = githubUrlParts[4];

        let installCommand = `npx create-eth@latest -e ${githubUsername}/${repoName}`;

        if (githubUrlParts.length > 5) {
          const branch = githubUrlParts[6];
          installCommand = `${installCommand}:${branch}`;
        }

        return {
          name: ext.name,
          description: ext.desc,
          github: ext.branch,
          installCommand,
          builder: ext.builder,
          coBuilders: ext.coBuilders || [],
          youtube: ext.videoUrl || null,
        };
      });

Maybe we can do it after merging this PR.

[Pabl0cks]

Looking good to me! 🙌

[damianmarti]

@Pabl0cks @carletex scaffold-eth/create-eth#155 is merged now (and published to create-eth), can we merge this?

[technophile-04]

Thanks @damianmarti and all for testing nd review 🙌

Just pushed a small tweak at e6f84c4 so that we take in consideration the version if provided by crated extension json and extensionFlagValue for constructing installCommand since it will be the actual truth for sure as discussed in scaffold-eth/create-eth#161