-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpeedRun Ethereum challenges as curated extensions #197
Conversation
"extensionFlagValue": "challenge-0-simple-nft", | ||
"description": "This extension sets up the environment for SpeedRun Ethereum Challenge 0: Learn the basics of Scaffold-ETH 2 by creating a simple NFT.", | ||
"repository": "https://github.com/scaffold-eth/se-2-challenges", | ||
"branch": "challenge-0-simple-nft--extension" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and all other final branches will be without --extension
}, | ||
{ | ||
"extensionFlagValue": "challenge-0-simple-nft", | ||
"description": "This extension sets up the environment for SpeedRun Ethereum Challenge 0: Learn the basics of Scaffold-ETH 2 by creating a simple NFT.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe SpeedRunEthereum
without spaces?
@@ -0,0 +1,5 @@ | |||
--- | |||
"create-eth": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will change this to minor version when we are ready to merge 🙌
Closing this, got 2 PRs for this #198 |
I think descriptions won't be visible anywhere, since they will be hidden from the SE-2 website, but added them to be inline with the others.
Closes #196