Skip to content

Commit

Permalink
Merge pull request #199 from scaffold-eth/backmerge-15-01-25
Browse files Browse the repository at this point in the history
backmerge 15-01-25
  • Loading branch information
carletex authored Jan 15, 2025
2 parents 6fdbc09 + ea59ec6 commit 187a179
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/mighty-stingrays-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"create-eth": patch
---

- Add contributing rules (https://github.com/scaffold-eth/scaffold-eth-2/pull/1031)
- Add vercel login script (https://github.com/scaffold-eth/scaffold-eth-2/pull/1027)
14 changes: 10 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,19 @@ Read the [README](README.md) to get an overview of the project.

The goal of create-eth is to be a "toolkit creator", using Scaffold-ETH 2 as a base to provide the primary building blocks for a decentralized application. In the future we plan to add "curated" packages to it, and open the possibility to import 3rd party packages (that follow our standard).

The repo can be forked to include integrations and more features.
The repo can be forked to include integrations and more features, but we want to keep the `main` branch simple and minimal.

### Project Status

The project is under active development.

You can view the open Issues, follow the development process and contribute to the project.
You can view the open Issues, follow the development process, and contribute to the project.

### Rules

1. All code contributions require an Issue to be created and agreed upon by core contributors before submitting a Pull Request. This ensures proper discussion, alignment, and consensus on the proposed changes.
2. Contributors must be humans, not bots.
3. First-time contributions must not contain only spelling or grammatical fixes.

## Getting started

Expand Down Expand Up @@ -57,7 +63,7 @@ Some tips to follow when you are creating an issue:

- Provide as much context as possible. Over-communicate to give the most details to the reader.
- Include the steps to reproduce the issue or the reason for adding the feature.
- Screenshots, videos etc., are highly appreciated.
- Screenshots, videos, etc., are highly appreciated.

### Pull Requests

Expand Down Expand Up @@ -86,7 +92,7 @@ Here are some tips for a high-quality pull request:

Once you submit your PR:

- We may ask questions, request additional information or ask for changes to be made before a PR can be merged. Please note that these are to make the PR clear for everyone involved and aims to create a frictionless interaction process.
- We may ask questions, request additional information, or ask for changes to be made before a PR can be merged. Please note that these are to make the PR clear for everyone involved and aim to create a frictionless interaction process.
- As you update your PR and apply changes, mark each conversation resolved.

Once the PR is approved, we'll "squash-and-merge" to keep the git commit history clean.
Expand Down
3 changes: 2 additions & 1 deletion templates/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"postinstall": "husky install",
"precommit": "lint-staged",
"vercel": "yarn workspace @se-2/nextjs vercel",
"vercel:yolo": "yarn workspace @se-2/nextjs vercel:yolo"
"vercel:yolo": "yarn workspace @se-2/nextjs vercel:yolo",
"vercel:login": "yarn workspace @se-2/nextjs vercel:login"
},
"packageManager": "[email protected]",
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion templates/base/packages/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"serve": "next start",
"start": "next dev",
"vercel": "vercel --build-env YARN_ENABLE_IMMUTABLE_INSTALLS=false --build-env ENABLE_EXPERIMENTAL_COREPACK=1 --build-env VERCEL_TELEMETRY_DISABLED=1",
"vercel:yolo": "vercel --build-env YARN_ENABLE_IMMUTABLE_INSTALLS=false --build-env ENABLE_EXPERIMENTAL_COREPACK=1 --build-env NEXT_PUBLIC_IGNORE_BUILD_ERROR=true --build-env VERCEL_TELEMETRY_DISABLED=1"
"vercel:yolo": "vercel --build-env YARN_ENABLE_IMMUTABLE_INSTALLS=false --build-env ENABLE_EXPERIMENTAL_COREPACK=1 --build-env NEXT_PUBLIC_IGNORE_BUILD_ERROR=true --build-env VERCEL_TELEMETRY_DISABLED=1",
"vercel:login": "vercel login"
},
"dependencies": {
"@heroicons/react": "~2.1.5",
Expand Down

0 comments on commit 187a179

Please sign in to comment.