up eslint packages + type check and format in pre-commit (#156)

.github/workflows/lint.yml

@@ -32,3 +32,6 @@ jobs:
 
       - name: Run lint
         run: yarn lint --max-warnings=0
+
+      - name: Run type-check
+        run: yarn type-check

lefthook.yml

@@ -1,5 +1,14 @@
 pre-commit:
+  parallel: true
   commands:
+    type-check:
+      glob: "src/**/*.ts"
+      run: yarn type-check
     lint:
       glob: "*.{js,ts,md}"
       run: yarn eslint --fix {staged_files}
+    format:
+      glob: "*.{js,ts,md,json}"
+      run: |
+        yarn prettier --write {staged_files}
+        git add {staged_files}

package.json

@@ -18,6 +18,7 @@
     "lint": "eslint .",
     "format": "prettier --write .",
     "test": "echo \"Error: no test specified\" && exit 1",
+    "type-check": "tsc --noEmit",
     "changeset:release": "yarn build && changeset publish"
   },
   "keywords": [
@@ -32,22 +33,22 @@
   ],
   "license": "MIT",
   "devDependencies": {
-    "@eslint/js": "^9.3.0",
+    "@eslint/js": "^9.15.0",
     "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-typescript": "11.1.0",
     "@types/inquirer": "9.0.3",
     "@types/ncp": "2.0.5",
     "@types/node": "18.16.0",
-    "eslint": "^9.3.0",
+    "eslint": "^9.15.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-prettier": "^5.1.3",
+    "eslint-plugin-prettier": "^5.2.1",
     "lefthook": "^1.6.16",
-    "prettier": "3.3.2",
+    "prettier": "^3.3.3",
     "rollup": "3.21.0",
     "rollup-plugin-auto-external": "2.0.0",
     "tslib": "2.5.0",
-    "typescript": "5.0.4",
-    "typescript-eslint": "^7.10.0"
+    "typescript": "^5.6.3",
+    "typescript-eslint": "^8.15.0"
   },
   "dependencies": {
     "@changesets/cli": "^2.26.2",

src/extensions.json

@@ -41,4 +41,4 @@
     "repository": "https://github.com/scaffold-eth/create-eth-extensions",
     "branch": "randao"
   }
-]
+]

src/utils/parse-arguments-into-options.ts

@@ -117,7 +117,7 @@ export async function parseArgumentsIntoOptions(
 
   // if lengh is 1, we don't give user a choice and set it ourselves.
   const solidityFramework =
-    solidityFrameworkChoices.length === 1 ? solidityFrameworkChoices[0] : args["--solidity-framework"] ?? null;
+    solidityFrameworkChoices.length === 1 ? solidityFrameworkChoices[0] : (args["--solidity-framework"] ?? null);
 
   if (solidityFramework === SOLIDITY_FRAMEWORKS.FOUNDRY) {
     await validateFoundryUp();

src/utils/system-validation.ts

@@ -4,7 +4,7 @@ import { execa } from "execa";
 export const validateFoundryUp = async () => {
   try {
     await execa("foundryup", ["-h"]);
-  } catch (error) {
+  } catch {
     const message = ` ${chalk.bold.yellow("Attention: Foundryup is not installed in your system.")}
  ${chalk.bold.yellow("To use foundry, please install foundryup")}
  ${chalk.bold.yellow("Checkout: https://getfoundry.sh")}

tsconfig.json

@@ -9,7 +9,5 @@
     "moduleResolution": "node",
     "resolveJsonModule": true
   },
-  "exclude": [
-    "node_modules"
-  ]
-}
+  "exclude": ["node_modules", "templates", "externalExtensions", "**/*.test.ts"]
+}