feat: setup OS proxy #207
Merged
feat: setup OS proxy #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianfeng92
commented
Oct 21, 2023
| @@ -20,10 +20,12 @@ | |||
| "dependencies": { | |||
| "@saucelabs/testcomposer": "^2.0.0", | |||
| "@tsconfig/node20": "20.1.2", | |||
| "@types/shelljs": "^0.8.14", | |||
There was a problem hiding this comment.
If it's listed under devDependencies, it won't be installed during the npm ci --production step, leading to a failure in the npm run build step.
Although it's not a runtime dependency, a deeper solution would require adjustments to the pipeline.
|
Since the setup is rather complex, it'd be good to have an e2e test for this scenario (one for mac, one for windows) 🙏 |
Co-authored-by: Alex Plischke <[email protected]>
Co-authored-by: Alex Plischke <[email protected]>
Co-authored-by: Alex Plischke <[email protected]>
Co-authored-by: Alex Plischke <[email protected]>
Co-authored-by: Alex Plischke <[email protected]>
alexplischke
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests with TestCafe and Chrome, it sets up the OS network proxy.
Some notes:
localhostto avoid disrupting the TestCafe startup process.I checked the DNS issue via testing with our internal artifact service.
Windows results:
Chrome: https://app.saucelabs.com/tests/8ff993c424a4468b84ea9bcd0642471c
Firefox: https://app.saucelabs.com/tests/e3ff70c4adcb4a7a994e20715d4696dd
Edge: https://app.saucelabs.com/tests/02c77ca62a034f66b2e1e69fe9f2e552
Mac results:
Chrome: https://app.saucelabs.com/tests/b82fadb3c09e4b31865cb8043310eb22
Firefox: https://app.saucelabs.com/tests/7293e17e1a6b44328f542c6e41abf9cb
Edge: https://app.saucelabs.com/tests/0d265e57875b42249fa1505d0e7b60d0