Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering availableFounders by slug #4503

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Dec 16, 2024

Changes

Allow filter availableFounders by slug

{
  getMetric(metric: "social_volume_total") {
    metadata {
      availableFounders(slug: "ethereum") {
        name
      }
    }
  }
}

Allow aggregated_timeseries_data for more social metrics

{
  getMetric(metric: "sentiment_positive_total") {
    aggregatedTimeseriesData(
      selector: {founders: ["satoshi nakamoto"]}
      from:"utc_now-40d"
      to: "utc_now") 
  }
}

Now providing a different aggregation also has effect. Before the aggregatedTimeseriesData used to ignore the provided aggregation and was using a hardcoded one instead.

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff force-pushed the filter-available-founders-by-slug branch from 09b2c72 to d7e93e1 Compare December 16, 2024 13:36
- Support the aggregated_timeseries_data for sentiment metrics, too.
- Extract the functionality in one function
- Allow for other aggregations to be provided via API
@IvanIvanoff IvanIvanoff merged commit e59733e into master Dec 16, 2024
4 checks passed
@IvanIvanoff IvanIvanoff deleted the filter-available-founders-by-slug branch December 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant