Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seeked time reset on player load in Safari #741

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix seeked time reset on player load in Safari #741

merged 1 commit into from
Dec 6, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Nov 15, 2024

Related issue: #728

@Dananji Dananji marked this pull request as ready for review December 2, 2024 19:29
cjcolvar
cjcolvar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine as far as I can tell although I am wondering if this creates duplicate event handling that could create duplicate playerDispatch events leading to potential race conditions.

@Dananji
Copy link
Collaborator Author

Dananji commented Dec 6, 2024 •
edited
Loading

I didn't run into race condition when testing this out. I'll make a note in the ticket for testing purposes.

@Dananji Dananji merged commit f685a99 into main Dec 6, 2024
2 checks passed
@Dananji Dananji deleted the safari-seek branch December 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar