This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
extended CSP handling #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the appropriate content security policies that is: - connect-src: for the hot-reload feature of webpack - font-src: for webpack-packaged fonts - style-src: for webpack-packaged stylesheets - script-src: for webpack-packaged javascripts
|
bump |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, only the
script-srcdirective gets the webpack dev server url appended and that under the assumption that i'd like myscript-srcreplaced the following way:replace
script-src 'self'withscript-src 'self' 'unsafe-eval' http://webpack.which only really works if i have a policy of excactly
script-src 'self' ....also, it does not append all the other necessary policies, that is:
connect-srcfor the hot-reload feature of webpackfont-srcfor webpack-packaged fontsstyle-srcfor webpack-packaged stylesheetsscript-srcfor webpack-packaged javascriptsthis patch fixes this.
also introduces proper testing (at least for this feature).