Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump revive to v1.3.7 #329

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

synarete
Copy link
Collaborator

@synarete synarete commented Feb 13, 2024

Bump revive version to v1.3.7 and fix the newly discovered errors.

fixes #327

Required minimal version or else 'make check-dockerfile-go-version'
fails.

Signed-off-by: Shachar Sharon <[email protected]>
Use latest revive checker.

Signed-off-by: Shachar Sharon <[email protected]>
Fixed unused parameter errors found by revive-v1.3.7.

Signed-off-by: Shachar Sharon <[email protected]>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mergify mergify bot merged commit abfb931 into samba-in-kubernetes:master Feb 13, 2024
13 checks passed
@mergify mergify bot added the priority-review This PR deserves a look label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-review This PR deserves a look
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI needs updating
3 participants