-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe Recovery Initial Setup #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we decide that we need a new module instead of choosing plenty of existing options? I cannot see any decision made in #348
I took a look at candide contracts and they seem to fit our requirements, except for the 4337. Theoretically, we may just inherit our contract from it and add a cc @Sednaoui |
I am not sure I understood the 4337 requirements needed for the Recovery Module. Can you please further clarify? From our knowledge:
Having |
For some additional context, we are considering adding "signature validator" support to the 4337 module to allow modules to be executed over 4337 (which is currently not possible with Safe and the 4337 module). |
Got it -- yes in that case the support for signature validators are quite beneficial. We can add support for it in the social recovery module if this is planned |
Based on internal discussion, we have decided we will be exploring currently available module options instead of creating a new one from scratch. So, this PR will be considered as "won't implement". |
This PR adds an empty NPM package for the Recovery Module, including:
hardhat-deploy
configurationInspired from #297, this PR fixes #350