Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace callsOnly byonlyCalls in README #802

Merged
merged 1 commit into from
May 7, 2024

Conversation

clemsos
Copy link
Contributor

@clemsos clemsos commented May 2, 2024

What it solves

There is a mistake in the README of the Safe protocol-kit where the args for createTransaction specifies a callsOnly param - while it should beonlyCalls.

You can see the types here

How this PR fixes it

This PR corrects the error in the README.

Also related : safe-global/safe-docs#459

Copy link

github-actions bot commented May 2, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@clemsos
Copy link
Contributor Author

clemsos commented May 2, 2024

I have read the CLA Document and I hereby sign the CLA

@dasanra dasanra changed the base branch from main to development May 7, 2024 08:50
@dasanra dasanra merged commit f3d9207 into safe-global:development May 7, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@clemsos clemsos deleted the patch-1 branch May 7, 2024 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants