-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol kit): Get modules paginated incorrect interface #787
Merged
yagopv
merged 12 commits into
feat/add-eip1193-provider
from
fix/protocol-kit/getModulesPaginated
May 8, 2024
Merged
fix(protocol kit): Get modules paginated incorrect interface #787
yagopv
merged 12 commits into
feat/add-eip1193-provider
from
fix/protocol-kit/getModulesPaginated
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8848383373Details
💛 - Coveralls |
leonardotc
force-pushed
the
fix/protocol-kit/getModulesPaginated
branch
2 times, most recently
from
April 26, 2024 14:32
9ca8c6f
to
2fae63e
Compare
leonardotc
force-pushed
the
fix/protocol-kit/getModulesPaginated
branch
2 times, most recently
from
April 26, 2024 14:49
caaf65c
to
4d2bf88
Compare
leonardotc
force-pushed
the
fix/protocol-kit/getModulesPaginated
branch
from
April 26, 2024 14:51
4d2bf88
to
ca970c3
Compare
leonardotc
force-pushed
the
feat/add-eip1193-provider
branch
from
April 29, 2024 07:21
46c0856
to
6f23e0b
Compare
…ated' into fix/protocol-kit/getModulesPaginated
…fix/protocol-kit/getModulesPaginated
…fix/protocol-kit/getModulesPaginated
…fix/protocol-kit/getModulesPaginated
…fix/protocol-kit/getModulesPaginated
This was added to the
|
yagopv
approved these changes
May 8, 2024
Beautiful @leonardotc thanks!. I think you need to pull from the target branch for fixing the failing tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
The method
getModulesPaginated
should return a tuple containing both the modules as well as the next address of the page.How this PR fixes it