Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate getProtocolKitVersion dynamically via prebuild script #1098

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

DaniSomoza
Copy link
Contributor

What it solves

Generate getProtocolKitVersion dynamically via prebuild script

Updated Packages: protocol-kit and realy-kit

"prebuild": "node -p \"'export const getProtocolKitVersion = () => \\'' + require('./package.json').version.split('-')[0] + '\\''\" > src/utils/getProtocolKitVersion.ts",

this generates a getProtocolKitVersion.ts in the utils folder:

export const getProtocolKitVersion = () => '5.1.1'

How this PR fixes it

Based on: https://github.com/safe-global/safe-apps-sdk/pull/512/files#diff-5f74fd08745aa25ded644cd9a4eff498e167ba539e633f87b200cd40e4113e06R23

@DaniSomoza DaniSomoza changed the base branch from main to development January 16, 2025 13:18
@DaniSomoza DaniSomoza self-assigned this Jan 16, 2025
@DaniSomoza DaniSomoza requested review from dasanra and yagopv January 16, 2025 13:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12809756516

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 75.236%

Totals Coverage Status
Change from base Build 12793210748: 0.04%
Covered Lines: 794
Relevant Lines: 983

💛 - Coveralls

@dasanra dasanra merged commit fdfb6c7 into development Jan 16, 2025
19 checks passed
@dasanra dasanra deleted the fix-get-version-as-script branch January 16, 2025 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants