Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service monitor matching labels #24

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix service monitor matching labels #24

merged 1 commit into from
May 27, 2024

Conversation

cedvan
Copy link
Contributor

@cedvan cedvan commented May 16, 2024

Actually this template generate

  selector:
    app.kubernetes.io/instance: ovh-mks-exporter
    app.kubernetes.io/name: ovh-mks-exporter
    matchLabels: null

instead of

  selector:
    matchLabels:
      app.kubernetes.io/instance: ovh-mks-exporter
      app.kubernetes.io/name: ovh-mks-exporter

So deployment is break because crd not match correctly, this error is generated :
.spec.selector.app.kubernetes.io/instance: field not declared in schema

Just add missing indentation to fix

@rverchere
Copy link
Owner

Good catch, thanks!

@rverchere rverchere merged commit f13cb05 into rverchere:main May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants