Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add axis_windows_with_stride() method #1460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add axis_windows_with_stride() method #1460

wants to merge 1 commit into from

Conversation

goertzenator
Copy link

This adds a variation of axis_windows() that accepts a stride parameter. It is analogous to the windows_with_stride() variant of windows(). This was already 95% implemented thanks to the work of @jonasBoss in commit 2aec819.

Ref issue #1304.

akern40
akern40 reviewed Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@akern40 akern40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is looking good, and great testing. Just the one question about keeping the name new. If you could run rustfmt (which must be run on +nightly) that would also be good.

src/iterators/windows.rs Show resolved Hide resolved
@akern40 akern40 linked an issue Dec 13, 2024 that may be closed by this pull request
NdProducer::Dim of axis_windows() should be Ix1 #1304
Open
@goertzenator goertzenator force-pushed the axis_windows_with_stride branch from 03fdd5f to c0961a6 Compare December 13, 2024 15:12
@goertzenator
Copy link
Author

cargo fmt from nightly has been applied to the PR.

@akern40
Copy link
Collaborator

akern40 commented Dec 14, 2024

Let me fix our CI/CD and then this should be good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akern40 akern40 akern40 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NdProducer::Dim of axis_windows() should be Ix1
2 participants
@goertzenator @akern40