Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add beta nominated to issues fixing regressions #1380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mibac138
Copy link
Contributor

@mibac138 mibac138 commented Jun 6, 2021

... from stable to beta

Fixes #1184

src/handlers/beta_backport.rs Outdated Show resolved Hide resolved
src/handlers/beta_backport.rs Outdated Show resolved Hide resolved
@mibac138
Copy link
Contributor Author

I've rebased and reworked the code. How does it look now?

@Mark-Simulacrum
Copy link
Member

This looks good -- sorry I missed your message last year(!). It looks like it needs a rebase, and then we can merge.

Comment on lines +6 to +10
lazy_static! {
// See https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-issues/linking-a-pull-request-to-an-issue
static ref CLOSES_ISSUE: Regex = Regex::new("(close[sd]|fix(e[sd])?|resolve[sd]) #(\\d+)").unwrap();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to trigger a beta-backport nomination for any PR that is fixing an issue, no matter if the originating issue is a regression and the channel (nightly, beta or stable) where the regression happened?

(sorry if I missing some context)

@apiraino
Copy link
Contributor

apiraino commented Jan 6, 2025

@Mark-Simulacrum I've left a new comment.

I'd like to have some mechanism to auto-nominate PRs for backport. Together with #1853 would be so cool for us T-compiler :-)

@mibac138 do you think you will have capacity to push the work further? I know it's awkward asking this after such long time. In case the work here is stale, I can try owning this patch and bring it to the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-nominate PRs for beta backport
3 participants