Made the list of exercises searchable, ref #2093 #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo8it
requested changes
Sep 3, 2024
…rch_query to apply_search_query
mo8it
approved these changes
Sep 3, 2024
| } | ||
| None => { | ||
| let msg = String::from(" (not found)"); | ||
| self.message.push_str(&msg); |
There was a problem hiding this comment.
No need to create a String here (it allocates). .push_str(" (not found)") is enough.
| match curr_key { | ||
| KeyCode::Esc | KeyCode::Enter => { | ||
| is_searching = false; | ||
| list_state.search_query.clear(); |
There was a problem hiding this comment.
We probably need to draw here to remove the search query. I will test it.
|
I will take care of the two comments myself. Merging for now. Very well implemented. Thank you! :D |
|
I made the final touches in da8b3d1, mostly subjective changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.