-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snyk to CircleCI pipeline #565
base: main
Are you sure you want to change the base?
Conversation
@@ -1,8 +1,9 @@ | |||
# Java Gradle CircleCI 2.0 configuration file | |||
# | |||
# Check https://circleci.com/docs/2.0/language-java/ for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link wasn't accurate anymore. Version 2.1 came out 6yrs ago.
.circleci/config.yml
Outdated
steps: | ||
- checkout | ||
- setup_remote_docker | ||
- git/rebase_on_main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, do we need to rebase on main? I see the PD git orb states its purpose is to prevent "unwanted merge checks from overwriting existing deployed code", but I don't think that applies here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably could. This was in the original template that SRE-Delivery worked with me on, but it's possible it's not relevant here. I'll take that out in the next iteration.
I have some other possible changes coming for the Snyk scan, so I'm just holding any more work on this PR until I've confirmed those changes. |
@megg-pd thanks, I'm doing some other changes to fix issues with the other actions |
@megg-pd will there be other changes to this PR? |
@gschueler Apologies, this is ready to go now. The main change was changing the failure threshold to "high". We were looking into making another change where it only fails when there's an upgrade path for vulnerable dependencies, however this would then make snyk hide the license policy violation failures, so we couldn't implement that tweak. |
939cabf
to
c0b8bf9
Compare
Context
This PR will enable Snyk Open Source scans in CircleCI.
Changes Include:
Engineering Team Code Owners Should Test, Validate, and Merge
Please update as needed and merge these PRs when you feel comfortable to do so.
We are asking the teams that own each repository to carefully test and merge these changes so they can monitor for any resulting issues, as they are more familiar with the code and deploy process.
Checklist for Team Code Owners
Checklist for Security Engineer