feat(job-create): enhancement for job creation #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotations as yaml, much more convenient, environment field as yaml to handle 'fieldRef', handle mapping of configmap keys just as secret were already handled BREAKING CHANGE: annotations and environement variables are in yaml now, so this is a breaking change
|
Hi @ThibaultLengagne |
ltamaster
requested changes
Apr 6, 2021
| @@ -25,16 +25,31 @@ def create_job_object(data): | |||
|
|
|||
| annotations = None | |||
| if "annotations" in data: | |||
| annotations_array = data["annotations"].split(',') | |||
There was a problem hiding this comment.
it could be better to keep this code to not break old jobs (maybe if the yaml parse failed, try with this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: annotations and environement variables are in yaml now