-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent name collision with private methods from ancestors #351
Conversation
@cjlarose are you happy with the change? I would like to merge it and release it as |
@vadtel tests are failing for Ruby 3.0. Would you mind having a look? |
It depends on the |
Yeah, possibly this would be the easiest solution. @cjlarose wdyt? |
Waiting for the feedback from @cjlarose before we merge it in and release it. Hopefully soon... |
Released with version 5.2.0 |
I caught error when accessing an option named
lambda
The methods used to access options are always public, so there is no need to use send. Using send can cause problems because it can call private and protected methods of the base classes. I replaced send with public_send. This will avoid the problems caused by send calling private and protected methods.