Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we use newest docker image when building #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ensure we use newest docker image when building #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ if [ "$RSA_PRIVATE_KEY" == "" ]; then
fi
echo PWD: $PWD
echo HOME: $HOME
docker pull rsyslog/docker-alpine-abuild:3.7 # be on the save side...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts:

  • Update the FROM line in your Dockerfile to reflect the latest stable upstream image:
-FROM	alpine:3.7
+FROM	alpine:latest

Whenever you build your image the Dockerfile would use the latest upstream stable image.

  • Either explicitly tag (or allow the default to apply) your new docker image with 'latest'.

Now when you call the docker run command, you could either explicitly specify that tag or allow docker to default to using that tag when fetching the image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful here. When 3.8 comes out, we still must support the 3.7 packages, and they can be different. For that reason, we need to nail the build to specific versions. The idea is to support all version also currently supported by Alpine. Right now that would be 3.6 and 3.7, but as 3.8 will come out soon, I am not digging into 3.6.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comment applies to the actual packaging content, not just the helper container

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Carry on then, ignore my chattering. ;)

docker run \
-e OWNER=`id -u` \
-e OWNER_GRP=`id -g` \
Expand Down