chore: not override rslib's rsbuild version when test plugins #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9aoy
changed the title
chenjiahan
reviewed
Jan 3, 2025
| @@ -74,6 +74,10 @@ export async function test(options: RunOptions) { | |||
| await $`pnpm exec playwright install --with-deps` | |||
| } | |||
| }, | |||
| overrides: { | |||
| // not override rslib's rsbuild version | |||
| '@rslib/core>@rsbuild/core': 'latest', | |||
There was a problem hiding this comment.
Can we keep the original version instead of using latest? Using latest can break Rslib in some cases.
There was a problem hiding this comment.
I don't know how to configure it here to keep the original version. Do you have any ideas? Don't want to write pnpmfile file which will complicate this matter. 😢
There was a problem hiding this comment.
How about:
const rslibPkg = require('@rslib/core/package.json');
rslibPkg.dependencies['@rsbuild/core'] || 'latest'There was a problem hiding this comment.
The rslib version needs to be obtained after install, or determined based on lock. But plugin build is during install (prepare stage).
chenjiahan
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not override rslib's rsbuild version when test plugins.
web-infra-dev/rslib#633