Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary revert cmake #176

Merged
merged 2 commits into from
Jul 19, 2020
Merged

Temporary revert cmake #176

merged 2 commits into from
Jul 19, 2020

Conversation

lategoodbye
Copy link
Collaborator

As long as cmake doesn't generate suitable deb packages (see #174 ), we need to
switch back :(

As long as cmake doesn't generate suitable deb packages, we need to
switch back :(
@lategoodbye lategoodbye merged commit e1f4dbd into master Jul 19, 2020
@fredrik-sk
Copy link
Contributor

fredrik-sk commented Jul 19, 2020

Did this change pass the CI pipelines? No.

https://github.com/rscada/libmbus/actions/runs/174538963

The code might work (but I am not sure since I have not seen proof).
I would assume that the file specifing how the automatic builds are executed should have been updated as well.

EDIT : When you are used to CI tests, you automatically ask yourself 'does this change effect the CI stuff".

@lategoodbye
Copy link
Collaborator Author

Did you noticed that the whole CI stuff based on cmake?

@fredrik-sk
Copy link
Contributor

fredrik-sk commented Jul 19, 2020 via email

fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Jul 19, 2020
fredrik-sk pushed a commit to fredrik-sk/libmbus that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants