Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N: Annotate indentation of the transaction summary #1999

Merged

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Jan 9, 2025

Translators are recommend to align the messages to prevent from a broken table:

Podsumowanie transakcji:
 Instalowanie:         6 pakietów
 Aktualizowanie:         33 pakietów
 Zastępowanie:         48 pakietów
 Usuwanie:         199 pakietów

Relates: https://bugzilla.redhat.com/show_bug.cgi?id=2336561

Translators are recommend to align the messages to prevent from
a broken table:

    Podsumowanie transakcji:
     Instalowanie:         6 pakietów
     Aktualizowanie:         33 pakietów
     Zastępowanie:         48 pakietów
     Usuwanie:         199 pakietów

(Last arguments moved to a new line to follow new clang-format.)

Relates: https://bugzilla.redhat.com/show_bug.cgi?id=2336561
@kontura
Copy link
Contributor

kontura commented Jan 10, 2025

I saw there are macros to provide context for translatable messages: https://github.com/rpm-software-management/dnf5/blob/main/include/libdnf5/utils/bgettext/README.md?plain=1#L56

It is used only on couple places, like:

repos_with_skipped_checks, C_("It is a joining character for repositories IDs", ", "));

However I don't know how it will show up to the translators or even if it is better then than normal comments.

@ppisar
Copy link
Contributor Author

ppisar commented Jan 10, 2025

Gettext context is used to differentiate two messages which are worded the identically in English, but needs different translation in other languages. Using them for belonging-to-summary-transaction-table would be an abuse and more importantly would not deliver the annotation to the translators.

@kontura
Copy link
Contributor

kontura commented Jan 10, 2025

I see, thanks.

@kontura kontura added this pull request to the merge queue Jan 10, 2025
Merged via the queue into rpm-software-management:main with commit 2d95658 Jan 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants