Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: bootc: Set 'installonlypkgs=' in /etc/dnf/dnf.conf #2183

Closed
wants to merge 1 commit into from

Conversation

dcantrell
Copy link
Contributor

On bootc installs, disable the installonlypkgs list so we do not end up with multiple kernels.

Fixes: SWM-3028

On bootc installs, disable the installonlypkgs list so we do not end
up with multiple kernels.

Fixes: SWM-3028

Signed-off-by: David Cantrell <[email protected]>
@evan-goode
Copy link
Member

Hmm, shouldn't detecting whether the system is bootc be done at runtime? Most often, this package will be installed during container build, and I don't think /run/ostree-booted will be set correctly then. Have you tested it?

@dcantrell
Copy link
Contributor Author

Oh, that's a fair point. I thought we could cheat with the RPM postinstall scriptlet but yeah, I think you're right about that test failing for a container build.

Reworking this PR...

@dcantrell dcantrell changed the title bootc: Set 'installonlypkgs=' in /etc/dnf/dnf.conf WIP: bootc: Set 'installonlypkgs=' in /etc/dnf/dnf.conf Jan 6, 2025
@jmarrero
Copy link
Contributor

jmarrero commented Jan 7, 2025

We are planning on doing: https://gitlab.com/fedora/bootc/base-images/-/blob/c09dadad8ff25018abbeec82ca603604c7b9b08f/tier-0/kernel-install.yaml#L11
on the bootc images.

@cgwalters
Copy link
Contributor

Our base container image could include a drop-in which updates the value here too right?

@cgwalters
Copy link
Contributor

Ohh duh that's what the MR is doing.

@evan-goode
Copy link
Member

We are planning on doing: https://gitlab.com/fedora/bootc/base-images/-/blob/c09dadad8ff25018abbeec82ca603604c7b9b08f/tier-0/kernel-install.yaml#L11

Nice, I think this PR is not needed then.

@dcantrell
Copy link
Contributor Author

Yeah, if this is handled on the other side we don't need this. I'll close it. Thanks.

@dcantrell dcantrell closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants