Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyQt6 #299

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

PyQt6 #299

wants to merge 23 commits into from

Conversation

AhmetCanSolak
Copy link
Collaborator

@AhmetCanSolak AhmetCanSolak commented Feb 17, 2023 •
edited
Loading

This PR help us drop PyQt5 and adopt PyQt6 as our main gui backend dependency. Will be addressing #298 .

@AhmetCanSolak AhmetCanSolak added the enhancement New feature or request label Feb 17, 2023
@AhmetCanSolak AhmetCanSolak self-assigned this Feb 17, 2023
@AhmetCanSolak
Copy link
Collaborator Author

CI is failing with qt6 and existing overlay.py implementation is not working with qt6.

@AhmetCanSolak AhmetCanSolak marked this pull request as ready for review April 10, 2023 18:16
@AhmetCanSolak AhmetCanSolak requested a review from keithchev April 10, 2023 22:46
@keithchev
Copy link
Contributor

keithchev commented Apr 15, 2023 •
edited
Loading

fwiw this installs on my M1 macbook and tests are running 😄

(I'm sure you're aware of this but lightgbm is currently missing from the dependencies for macs; I know you mentioned building this from source on M1 but some reason this was pip-installable for me without any effort)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithchev keithchev Awaiting requested review from keithchev

Assignees

@AhmetCanSolak AhmetCanSolak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmetCanSolak @keithchev