Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destructors should be public virtual #210

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Fix destructors should be public virtual #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/robot_state_publisher/joint_state_listener.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class JointStateListener {


/// Destructor
~JointStateListener();
virtual ~JointStateListener();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but I think making it virtual will break ABI. We try to avoid breaking ABI in released distros. Would you be willing to make the destructor protected instead?


private:
std::string getTFPrefix();
Expand Down
2 changes: 1 addition & 1 deletion include/robot_state_publisher/robot_state_publisher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class RobotStatePublisher
RobotStatePublisher(const KDL::Tree& tree, const urdf::Model& model = urdf::Model());

/// Destructor
~RobotStatePublisher(){};
virtual ~RobotStatePublisher() = default;

/** Publish transforms to tf
* \param joint_positions A map of joint names and joint positions.
Expand Down