feat: frontmatter #127
feat: frontmatter #127
Conversation
| # https://github.com/rstudio/blogdown/blob/9c7f7db5f11a481e1606031e88142b4a96139cce/R/utils.R#L407 | ||
| # anotate seq type values because both single value and list values are | ||
| # converted to vector by default | ||
| yaml_load = function(x) yaml::yaml.load( |
There was a problem hiding this comment.
Was this used anywhere? Not in the tests at least 😅
There was a problem hiding this comment.
Thank you! Sorry I haven't had time to get to this... I borked my home computer last week and haven't been able to get to this -_-
This looks good and pretty much is exactly what I was expecting! The only thing that is blocking is the regex for the JSON header was swallowing chunks at the beginning of documents.
Note that this will require some coordination with the carpentries to release because this will cause a lot of warnings (try testing pegboard with this release and you get over 70 warnings)
Co-authored-by: Zhian N. Kamvar <[email protected]>
|
@zkamvar the warnings you see in pegboard are the deprecations, correct? |
|
I have the impression we're getting the deprecation warning even when not accessing YAML actually. Is there another example of an R6 class deprecating a class that you know of and that I could look at? |
|
Or actually no 🤔 Not sure what I was seeing earlier. |
|
Forgot to write, thank you for the review! |
Yes, those are the deprecation warnings. This is because pegboard's |
Fix #126