Skip to content

Commit

Permalink
Set seed = FALSE in future::future()
Browse files Browse the repository at this point in the history
  • Loading branch information
wlandau-lilly committed Oct 11, 2023
1 parent 99cf01f commit b6c8ad8
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Add new arguments `meta`, `progress`, `process`, and `crew` to control individual metadata files in `tar_meta_upload()`, `tar_meta_download()`, `tar_meta_sync()`, and `tar_meta_delete()`.
* Avoid newly deprecated arguments and functions in `crew` 0.5.0.9003 (https://github.com/wlnadau/crew/issues/131).
* Allow `tar_read()` etc. inside a pipeline whenever it uses a different data store (#1158, @MilesMcBain).
* Set `seed = FALSE` in `future::future()` (#1166, @svraka).

# targets 1.3.0

Expand Down
2 changes: 1 addition & 1 deletion R/class_future.R
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ future_class <- R6::R6Class(
label = target_get_name(target),
resources = resources,
lazy = FALSE,
seed = 0L
seed = FALSE
)
future <- do.call(what = future::future, args = args)
memory_set_object(
Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test-class_clustermq.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
tar_test("clustermq$workers", {
skip_cran()
out <- clustermq_init(list(), workers = 3L)
expect_equal(out$workers, 3L)
})
Expand Down Expand Up @@ -269,6 +270,7 @@ tar_test("cover the worker shutdown step in clustermq$iterate() event loop", {
})

tar_test("clustermq$validate()", {
skip_cran()
out <- clustermq_init(pipeline_init())
expect_silent(out$validate())
})
1 change: 1 addition & 0 deletions tests/testthat/test-tar_make_clustermq.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
crew_test_sleep()

tar_test("tar_make_clustermq() works with callr_function = NULL", {
skip_cran()
skip_on_os("windows")
skip_on_os("solaris")
require_clustermq()
Expand Down

0 comments on commit b6c8ad8

Please sign in to comment.