Detection for vips 1 not longer works #46
Conversation
|
Thanks. Looks like we need to check the tests also.. Something is not working on them |
|
@chregu looks like |
| 'no_superfluous_phpdoc_tags' => false, | ||
| 'fully_qualified_strict_types' => false, | ||
| 'native_function_invocation' => false, | ||
| 'no_null_property_initialization' => false, | ||
| 'phpdoc_trim' => false, | ||
| 'blank_line_before_statement' => false, | ||
| 'phpdoc_add_missing_param_annotation' => false, | ||
| 'modernize_strpos' => false, | ||
| 'trailing_comma_in_multiline' => false, | ||
| 'no_whitespace_in_blank_line' => false, |
There was a problem hiding this comment.
to reduce too much changes inside this PR but still allow to test against PHP 8.4
There was a problem hiding this comment.
Linter changes are totally fine for me. That doesn't change functionality
|
I hope I got it running now all let me know If I should change anything else. |
|
BTW, it's also fine to get rid of support for non supported PHP versions. If that makes life easier |
| - name: Debug PHP settings | ||
| run: | | ||
| php -r 'echo "Has VIPS Extension: " . (extension_loaded("vips") ? "true" : "false") . PHP_EOL; echo "Has FFI Extension: " . (extension_loaded("ffi") ? "true" : "false") . PHP_EOL; echo "Has FFI Class: " . (class_exists(FFI::class) ? "true" : "false") . PHP_EOL; echo "Has FFI Enabled: " . (ini_get("ffi.enable") === "1" ? "true" : "false") . PHP_EOL; echo "Has zend.max_allowed_stack_size correct: " . (ini_get("zend.max_allowed_stack_size") === "-1" ? "true" : "false") . PHP_EOL;' | ||
|
|
There was a problem hiding this comment.
I will keep this may helpful in future?
|
@chregu currently see no need yet to drop them. Seems to still work fine on older versions :) |
Even better ;) |
|
Since all tests go through now, I think we can easily merge this, right? |
|
@chregu all fine from my side to merge it. |
|
Thanks ;) and sorry for the delay |
|
@chregu no problem is not urgent :) |
The implementation previously was f159d24
Not sure when but
if (\method_exists(Config::class, 'ffi')) {was replaced byclass_exists(FFI::class)which seems now not longer fallback then to check for v1 version as FFI class always exist im basic PHP core installations.