Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN-2798 - Opsgenie slack #1673
base: master
Are you sure you want to change the base?
MAIN-2798 - Opsgenie slack #1673
Changes from 4 commits
f02485c
ce26d0f
4ed670e
bfeeb99
942c279
f00c17b
84bc668
41ab137
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If in the future we will have mutlipe action what will happen? Why we aren't also checking the action name and making sure that this is indeed the action block and not only assume it is the first one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screen shot of the slack action, in the future it will be broken.
This is not currently a functionality we can support or handle on our end so more dev will need to be done to support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we can't find the right action using the text of something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name is not always guaranteed, the text here has no action as you see
The only thing guarenteed here is the block_id that was clicked in the callback
Also simplicity is key, if we overcomplicate it by searching for specific text and the text changes in runner that is worse than relying on the ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly i don't think it is worst, If you think it is high effort open ticket to support multiple action in that case and we will do it on next sprint.
Thanks.