chore(create-screenshots.sh): change file mode to executable refactor(puppeteer.js): reformat launch arguments for readability, replace hardcoded viewport dimensions with variables feat(puppeteer.js): change page load strategy to 'networkidle2' for more reliable screenshot capture #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(puppeteer.js): reformat launch arguments for readability, replace hardcoded viewport dimensions with variables feat(puppeteer.js): change page load strategy to 'networkidle2' for more reliable screenshot capture The file mode of create-screenshots.sh was changed to executable to allow direct execution of the script. The launch arguments in puppeteer.js were reformatted and spread across multiple lines for better readability and maintainability. The hardcoded viewport dimensions were replaced with variables for flexibility and to avoid magic numbers. The page load strategy was changed to 'networkidle2' to ensure that all network connections are idle before capturing the screenshot, providing a more reliable screenshot of the fully loaded page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file mode of create-screenshots.sh was changed to executable to allow direct execution of the script. The launch arguments in puppeteer.js were reformatted and spread across multiple lines for better readability and maintainability. The hardcoded viewport dimensions were replaced with variables for flexibility and to avoid magic numbers. The page load strategy was changed to 'networkidle2' to ensure that all network connections are idle before capturing the screenshot, providing a more reliable screenshot of the fully loaded page.