Initial refactor and tests of the text_box class (and derived classes) #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few things to discuss here, I think. Proposing to move many of the 'demo' functions to a demo class so that the code files can be pure implementation. If this looks good, I've got some (local) commits to do a similar refactor for other box classes. The imports and usage of the methods should all be staying the same here: due to the way that we set the |
zadacka
force-pushed
the
feature/refactor_and_test_text_box
branch
from
d03e623 to
bd3afcb
Compare
Removes Python 2.7 compatibility! (re)add the mouse click behaviour that the refactor had removed (re) add docstrings for the text_box and derived methods (used by sphinx) Move Al's test_easygui.py integration tests to the 'tests' folder for consistency use 1x README.rst instead of (duplicate) .txt and .md README files tweak conda meta.yaml so that bld.bat and build.sh aren't needed rename 'test_cases' -> 'demos' change mose_click_handlers -> MouseClickHandler class remove test_travis.py since we now have enough *real* tests, and Travis is working nicely remove duplicate 'parse_hotkey' method remove 'developer information' remove unused methods (exception_format, uniquify_list_of_strings, getFileDialogTitle, to_string) remove unused constant definitions remove tk 8.0+ warning since it looks like it is now bundled for all 'current' python (v3.7+) Tests will live in the 'tests' directory Demos will live in the 'demos' folder Remove some 'about' files to de-clutter the project. Aim: have more functional files, and less 'print this' type files everywhere. In order to do this, move the 'version' information to __init__.py * use it from the demo boxes *and* from setup.py Moving things from easygui.boxes.__init__ to easygui.boxes.utils ... in preparation of getting rid of boxes directory entirely. I want to keep the easygui.__init__ for import control, and move utilites to 'utils' add more interesting things to the button_box.py default parameter values
zadacka
force-pushed
the
feature/refactor_and_test_text_box
branch
from
f398047 to
df92528
Compare
… file in the package
…e consistently put in the AbstractBox class
…onBox which is special)
main change the preselect changing list -> tuple (because mutable arguments bad)
…-> monospace mixed feelings about the parameter rename (breaking change!) but otherwise reasonable tidy-up
Without a .protocol() binding for this the root.destroy() can get called twice causing errors
* expose the message (for future updates, if needed) * pull the button setting up to the AbstractBox
requires pulling out msg setting so that we can (for this box) put an image at the top and set msg underneath, which is hard to do if the msg setting happens in the super().__init__() method
|
I think that is the main refactor done. Most boxes now inherit from an AbstractBox which allows for a good amount of code re-use. Things that I'd like to do pre-merge:
Once the refactor lands, then I think that we can do some tidying up of the docs and finally make some headway on the open issues / bugs / feature requests that have been stacking up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of a series of proposed commits to simplify, reduce duplication, and add testing to box classes