Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Put ASAN CFLAGS in one place #4833

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jan 11, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr just puts the ASAN CFLAGS in one place to make it easier to copy-and-paste them.

Test plan

All builds are green.

Closing issues

...

@Rot127
Copy link
Member

Rot127 commented Jan 11, 2025

We could also try and add UBSAN at some point.

@kazarmy
Copy link
Member Author

kazarmy commented Jan 11, 2025

meson_options: -Dbuildtype=debugoptimized -Db_lundef=false -Db_sanitize=address,undefined --werror

-Db_sanitize=address,undefined does include UBSAN if I'm not mistaken.

@kazarmy kazarmy merged commit ae0aa42 into rizinorg:dev Jan 11, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants