Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@?: Add note on application of multiple @-modifiers #4815

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jan 2, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr adds a note to @? regarding application of multiple @-modifiers. I think it's more natural (and preferable) for the application to be left-to-right rather than right-to-left, but that's a story for another pr.

Test plan

The changes make sense.

Closing issues

...

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that actually checks @ behaves this way?

@kazarmy
Copy link
Member Author

kazarmy commented Jan 2, 2025

Do we have a test that actually checks @ behaves this way?

rizin/test/db/cmd/cmd_px

Lines 394 to 396 in 21d308b

NAME=pxi
FILE=malloc://0xd+0x30
CMDS=pxi @!0x10+0x30 @x:f30f1efa554889e5ebfe

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue please about the LTR/RTL behavior please too

@kazarmy
Copy link
Member Author

kazarmy commented Jan 2, 2025

Ok #4816

@kazarmy kazarmy merged commit 3fda7f7 into rizinorg:dev Jan 2, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants