Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix compilation with meson 1.3.0 #3995

Merged
merged 5 commits into from
Dec 1, 2023
Merged

build: fix compilation with meson 1.3.0 #3995

merged 5 commits into from
Dec 1, 2023

Conversation

ret2libc
Copy link
Member

@ret2libc ret2libc commented Nov 21, 2023 •
edited by XVilka
Loading

DO NOT SQUASH

XVilka

This comment was marked as resolved.

Sign in to view

@ret2libc ret2libc force-pushed the dist-fix-meson-1.3.0 branch from d40f131 to 435f384 Compare November 24, 2023 09:00
XVilka

This comment was marked as resolved.

Sign in to view

@ret2libc ret2libc force-pushed the dist-fix-meson-1.3.0 branch from 435f384 to 706ff75 Compare November 24, 2023 13:57
@XVilka XVilka mentioned this pull request Nov 24, 2023
Closed
@ret2libc ret2libc mentioned this pull request Nov 27, 2023
Merged
5 tasks
@ret2libc
build: fix compilation with meson 1.3.0
5d50710
@ret2libc
Revert "ci: downgrade Meson to 1.2.3 (#3991)"
ec553d6 
This reverts commit 6aeea82.
@ret2libc
Revert "Downgrade Docker Meson to 1.2.3 (#3994)"
6af9a80 
This reverts commit 94d7ccc.
@ret2libc
ci: use default meson even in create-tarball
41ece7a
@ret2libc
test: temporarily disable test_rz_analysis_var
8234775 
There is an issue when running it under UBSAN, however this issue has
always been there but it presents itself only with some specific values
of MALLOC_PERTURB. We are temporarily disabling this because we need to
fix an issue with meson-1.3.0 so that people can easily compile the
project.
@ret2libc ret2libc force-pushed the dist-fix-meson-1.3.0 branch from 52a7da8 to 8234775 Compare December 1, 2023 12:26
@ret2libc ret2libc requested a review from XVilka December 1, 2023 12:26
@ret2libc
Copy link
Member Author

ret2libc commented Dec 1, 2023 

>>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MALLOC_PERTURB_=252 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /__w/rizin/rizin/rizin/build/test/unit/test_subprocess
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
test_noargs_noinput_outerr OK
Hello World
Hello World
test_args OK
test_env OK
test_stdin OK
test_multi OK
test_specialchar_args OK
test_nopipes OK
test_stdoutonly OK
test_stderronly OK
test_stdoutstderr OK
test_interactive OK
test_interactive_pty OK
test_interactive_custom_pty OK
test_interactive_not_raw_pty ERR
[XX] Fail at line 367: No 3 + 5 + c: expected 2072314[104](https://github.com/rizinorg/rizin/actions/runs/7059979643/job/19218680371?pr=3995#step:7:105), got 2072.

stderr:
This is on err
This is on err

I saw this failing also on separate PR :( i'd be for merging this anyway and fix this before release.

@XVilka XVilka merged commit 953e1fb into dev Dec 1, 2023
56 of 57 checks passed
@kazarmy kazarmy mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
high-priority infrastructure merge-when-green rz-test
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ret2libc @XVilka