Fix FNEQ: x and y were interchanged. #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
wargio
reviewed
Nov 13, 2023
wargio
approved these changes
Nov 13, 2023
|
I'll fix the tests after @Heersin took a look. |
|
The compare of floats is not really well tested. These macros would be tested with the Hexagon code though. |
wargio
approved these changes
Nov 14, 2023
|
@Heersin Will you find time to look at it in the next days? I need it for the Hexagon uplifting and would just proceed if you can't find the time. |
sure, reviewing it now. |
Heersin
approved these changes
Nov 18, 2023
Heersin
approved these changes
Nov 18, 2023
It now includes the test for NaN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Fixes the
FEQmacro by changing thexandyoperand positions and checking forNaN.It also adds common compare operations as macros.
Test plan
...
Closing issues
...