Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This fixes a reachable
assert()
reached with Capstone v6. The operands used to calculate the jump target, used whatever was in the union of the operand value field.This also means that the previous calculation of
jump targets were simply incorrect.
Since it never checks if the offset operand is a register or an immediate, it uses the enum value of the register (or something else) as offset in the first case.Seems like we were lucky and
MEMDISP()
was always set to 0 in this case.Test plan
One test added so far.
A new switch test is needed as well.
Closing issues
closes #3965