Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor <fields> from RzList to RzPVector in RzBinPlugin #3962

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Refactor <fields> from RzList to RzPVector in RzBinPlugin #3962

merged 3 commits into from
Nov 8, 2023

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Nov 6, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

CI is green.

Closing issues

partially address #3775 and #3755

wargio
wargio requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

librz/bin/p/bin_coff.c Outdated Show resolved Hide resolved
@XVilka
Copy link
Member

XVilka commented Nov 7, 2023

@PeiweiHu 2 broken tests, please also rebase

@github-actions github-actions bot removed the rz-test label Nov 8, 2023
@wargio wargio merged commit a881956 into rizinorg:dev Nov 8, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
API ELF Mach-O merge-when-green PE rz-diff RzBin RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeiweiHu @XVilka @wargio