Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable show short/full function names in Vv mode #3958

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Nov 6, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

While trying to solve #1779, I found there already is an implementation to achieve this (not scroll but show the full name directly), which binds to [ and ]. This pr makes left and right arrows perform the same action as [ and ] and appends help info.

IMO this is more useful than scrolling the selected function name since it can show full names of many functions at the same time. The implementation that scrolls the selected function name seems less meaningful since when you select it, the right panel (i.e., pdf in the following pics) already shows the function with its name.

Test plan

...

Closing issues

closes #1779

image

image

librz/core/tui/vmenus.c Outdated Show resolved Hide resolved
@PeiweiHu PeiweiHu requested a review from wargio November 9, 2023 05:20
@XVilka XVilka merged commit eabd3e7 into rizinorg:dev Nov 9, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vv mode left/right arrows should scroll the function name, not switch to the variables
3 participants