-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debuginfod support #3954
Add debuginfod support #3954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to think about how to test this automatically without relying too much on external services. By running a debuginfod mock server of our own?
We can run a local private server when run CI.
|
c2b5fa0
to
471b503
Compare
7888b71
to
378ede2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. We need to make sure debuginfod
is present on the CI for this test though, or maybe run it only on Linux systems, just like debugging tests.
76e8bf9
to
9b2b142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as resolved.
This comment was marked as resolved.
9b2b142
to
fb2504a
Compare
Add rz_bin_dwarf_from_debuginfod
This reverts commit 638075a.
7575d8c
to
cec088a
Compare
Add rz_bin_dwarf_from_debuginfod
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
closes #1285