Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdb from rz_util_includes #3938

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 23, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr just removes sdb from rz_util_includes since there's nothing in the referred directory that is includable, and #include <src/...> looks weird.

Test plan

All builds are green.

Closing issues

...

@kazarmy kazarmy force-pushed the dist-rm-sdb-include-path branch from d9bed9a to 5250f15 Compare October 23, 2023 12:13
@kazarmy
Copy link
Member Author

kazarmy commented Oct 23, 2023

rz-bindgen redness seems unrelated

@ret2libc
Copy link
Member

rz-bindgen redness seems unrelated

It is

@XVilka XVilka merged commit d8332c5 into rizinorg:dev Oct 23, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants