Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fix memleaks #3923

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Try fix memleaks #3923

merged 1 commit into from
Oct 14, 2023

Conversation

imbillow
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

closes #3917

@imbillow imbillow requested review from XVilka and Rot127 October 13, 2023 21:35
Rot127
Rot127 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! This is way better!
We still have a few leaks, but those are in the Tricore and some function var code. Should be fixed separately IMHO.

@XVilka XVilka merged commit a974cbc into dev Oct 14, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@XVilka XVilka XVilka approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
DWARF RzAnalysis RzBin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memleaks in DWARF module
3 participants
@imbillow @XVilka @Rot127