Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a double free. #3918

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix a double free. #3918

merged 1 commit into from
Oct 16, 2023

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Oct 12, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

If the operand is rw, av gets assigned to op->src[i] and op->dst. Later when op is freed, op->src[i] and op->dst are freed both and so we run into the double free.

This shouldn't be the case for Tricore, but if it does, it breaks badly.

Test plan

All green.

Closing issues

...

@Rot127
Fix a double free.
00f9994 
If the operand is rw, av gets assigned to op->src[i] and op->dst.
Later when op is freed, op->src[i] and op->dst are freed both and
so we run into the double free.
@Rot127 Rot127 requested a review from thestr4ng3r as a code owner October 12, 2023 20:28
XVilka
XVilka approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imbillow take a look too, please.

@XVilka XVilka merged commit 51c8be0 into rizinorg:dev Oct 16, 2023
43 checks passed
@Rot127 Rot127 deleted the fix-double-free branch October 17, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbillow imbillow imbillow approved these changes

@XVilka XVilka XVilka approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees

@imbillow imbillow

Labels
RzAnalysis
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Rot127 @XVilka @imbillow